Added "cjk" analyzer. #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikePieperSer
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
MikePieperSer
force-pushed
the
add_cjk
branch
2 times, most recently
from
394c905
to
7e477d6
Compare
reta
reviewed
Aug 21, 2023
reta
reviewed
Aug 21, 2023
java-client/src/main/java/org/opensearch/client/opensearch/_types/analysis/CjkAnalyzer.java
Show resolved
Hide resolved
|
Ahhh, DCO check is failing for some reasons ... |
reta
previously approved these changes
Aug 21, 2023
|
Sorry, gave my complete name, again. Shall I fix it and force push? |
Yes please, thank you |
VachaShah
previously approved these changes
Aug 21, 2023
There was a problem hiding this comment.
This is great, thanks @MikePieperSer!
It would also be helpful if we have these code snippets listed in the user guide in an upcoming PR.
|
Also can you please fix the merge conflicts since the other PR is merged? |
dblock
reviewed
Aug 21, 2023
| @@ -90,6 +90,8 @@ public enum Kind implements JsonEnum { | |||
|
|
|||
| Whitespace("whitespace"), | |||
|
|
|||
| Cjk("cjk"), | |||
Signed-off-by: pieper <[email protected]>
Signed-off-by: pieper <[email protected]>
Signed-off-by: pieper <[email protected]>
Signed-off-by: pieper <[email protected]>
|
Can we also backport this to 2.x please? |
reta
approved these changes
Aug 22, 2023
VachaShah
approved these changes
Aug 22, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-604-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e8fcb43ea2e0ee67079bd092a9d1a5da9d90bff7
# Push it to GitHub
git push --set-upstream origin backport/backport-604-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
VachaShah
pushed a commit
to VachaShah/opensearch-java
that referenced
this pull request
Aug 22, 2023
* Added "cjk" analyzer. Signed-off-by: pieper <[email protected]> * Adapted changelog. Signed-off-by: pieper <[email protected]> * Fixed license headers. Signed-off-by: pieper <[email protected]> * Tab vs. Spaces fix. Signed-off-by: pieper <[email protected]> --------- Signed-off-by: pieper <[email protected]> Signed-off-by: Vacha Shah <[email protected]>
reta
pushed a commit
that referenced
this pull request
Aug 22, 2023
* Added "smartcn" analyzer. (#605) * Added "smartcn" analyzer. Signed-off-by: pieper <[email protected]> * Adapted changelog. Signed-off-by: pieper <[email protected]> * Fixed license headers. Signed-off-by: pieper <[email protected]> * Fixed release number. Signed-off-by: pieper <[email protected]> --------- Signed-off-by: pieper <[email protected]> Signed-off-by: Vacha Shah <[email protected]> * Added "cjk" analyzer. (#604) * Added "cjk" analyzer. Signed-off-by: pieper <[email protected]> * Adapted changelog. Signed-off-by: pieper <[email protected]> * Fixed license headers. Signed-off-by: pieper <[email protected]> * Tab vs. Spaces fix. Signed-off-by: pieper <[email protected]> --------- Signed-off-by: pieper <[email protected]> Signed-off-by: Vacha Shah <[email protected]> --------- Signed-off-by: pieper <[email protected]> Signed-off-by: Vacha Shah <[email protected]> Co-authored-by: MikePieperSer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for "cjk" analyzer.
Issues Resolved
Closes #592
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.