Refactor workflow step resource updates to eliminate duplication #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
============================================
+ Coverage 75.38% 77.30% +1.92%
- Complexity 917 922 +5
============================================
Files 96 96
Lines 4456 4345 -111
Branches 412 412
============================================
Hits 3359 3359
+ Misses 925 814 -111
Partials 172 172 ☔ View full report in Codecov by Sentry. |
dbwiddis
force-pushed
the
refactor-state-updates
branch
from
909ff00
to
68a73ed
Compare
dbwiddis
force-pushed
the
refactor-state-updates
branch
from
52c63dd
to
e6a2bf1
Compare
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
refactor-state-updates
branch
from
e6a2bf1
to
24e2a00
Compare
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
refactor-state-updates
branch
from
24e2a00
to
2648713
Compare
joshpalis
approved these changes
Aug 13, 2024
owaiskazi19
approved these changes
Aug 14, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
* Refactor workflow step resource updates to eliminate duplication Signed-off-by: Daniel Widdis <[email protected]> * Add coverage and changelog Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit dc20feb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Aug 14, 2024
…uplication (#835) Refactor workflow step resource updates to eliminate duplication (#796) * Refactor workflow step resource updates to eliminate duplication * Add coverage and changelog --------- (cherry picked from commit dc20feb) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
addResourceToWorkflowStatemethod to theFlowFrameworkIndicesHandlerwhich handles all the common handling / exception handling of resource updates.Other misc. cleanup of unused variables.
Related Issues
A step toward #779 which is now on hold, but as I was mostly done with this part I finished it.
A result of #763 (comment)
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.