Improve Template and WorkflowState builders #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
changed the title
Signed-off-by: Daniel Widdis <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
============================================
+ Coverage 74.54% 74.98% +0.44%
- Complexity 783 800 +17
============================================
Files 84 84
Lines 3873 3910 +37
Branches 356 365 +9
============================================
+ Hits 2887 2932 +45
+ Misses 829 824 -5
+ Partials 157 154 -3 ☔ View full report in Codecov by Sentry. |
owaiskazi19
approved these changes
Jul 12, 2024
amitgalitz
reviewed
Jul 18, 2024
amitgalitz
approved these changes
Jul 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Simplify Template builder instantiation Signed-off-by: Daniel Widdis <[email protected]> * Add ability to more easily update WorkflowState Signed-off-by: Daniel Widdis <[email protected]> * Changelog, initialize template parser Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit f40890c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jul 18, 2024
Improve Template and WorkflowState builders (#778) * Simplify Template builder instantiation * Add ability to more easily update WorkflowState * Changelog, initialize template parser --------- (cherry picked from commit f40890c) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the syntax for
Templatebuilder to the common static.builder()instantiation.WorkflowStatealready had a staticbuilder()but it wasn't enforced. Also added partial state update capability, to improve updating resource states during deprovisioning (to address #691) and eventually migrate away from painless scripts.Related Issues
Fixes #713
Fixes #776
Check List
[ ] API changes companion pull request created.--signoff.[ ] Public documentation issue/PR created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.