Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only pull security plugin zip if security enabled #423

Closed
wants to merge 1 commit into from

Conversation

joshpalis
Copy link
Member

Description

Conditionally pulls in security plugin zip if security is enabled. Security is only enabled when running security enabled integration tests. ./gradlew assemble now passes if security is unavailable.

More context can be found here

Issues Resolved

#410

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed here #418

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (789fc4d) 71.85% compared to head (4e121fb) 71.85%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #423   +/-   ##
=========================================
  Coverage     71.85%   71.85%           
  Complexity      614      614           
=========================================
  Files            79       79           
  Lines          3084     3084           
  Branches        237      237           
=========================================
  Hits           2216     2216           
  Misses          763      763           
  Partials        105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshpalis
Copy link
Member Author

joshpalis commented Jan 20, 2024

@owaiskazi19 those modifications will fail if security plugin isnt available. We will face this issue again in the next release. You can test by modifying the security dependency version to something that does not exist (like 4.0.0.0) to simulate a missing security plugin artifact and running ./gradlew assemble. This will fail assembling our plugin since the artifact does not exist.

If we conditionally exclude the security dependency, then a missing security artifact still wont break our build

@joshpalis joshpalis closed this Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants