Adding multi node IT and update API bug fixes #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitgalitz
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler and
jackiehanyang
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
============================================
+ Coverage 71.85% 71.90% +0.05%
- Complexity 614 622 +8
============================================
Files 79 79
Lines 3084 3136 +52
Branches 237 238 +1
============================================
+ Hits 2216 2255 +39
- Misses 763 774 +11
- Partials 105 107 +2 ☔ View full report in Codecov by Sentry. |
amitgalitz
force-pushed
the
multinode-IT
branch
2 times, most recently
from
23c1897
to
df5cb26
Compare
joshpalis
reviewed
Jan 18, 2024
src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java
Outdated
Show resolved
Hide resolved
dbwiddis
approved these changes
Jan 19, 2024
src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/rest/FlowFrameworkRestApiIT.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/rest/FlowFrameworkRestApiIT.java
Outdated
Show resolved
Hide resolved
|
@dbwiddis @joshpalis @owaiskazi19 multi node tests might still be flaky here, but i think we should push and continue to work on fixing this with additional PRs. we should at least have this on every PR we submit |
amitgalitz
force-pushed
the
multinode-IT
branch
2 times, most recently
from
803c6e9
to
c475303
Compare
Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
amitgalitz
force-pushed
the
multinode-IT
branch
from
c475303
to
e5f7fb7
Compare
owaiskazi19
approved these changes
Jan 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 20, 2024
* add multi node IT, fix update api bugs Signed-off-by: Amit Galitzky <[email protected]> * adding test and stashing context Signed-off-by: Amit Galitzky <[email protected]> * cleaning up comments and adding tests Signed-off-by: Amit Galitzky <[email protected]> --------- Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit a6ac83a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closed
owaiskazi19
pushed a commit
that referenced
this pull request
Jan 20, 2024
Adding multi node IT and update API bug fixes (#416) * add multi node IT, fix update api bugs * adding test and stashing context * cleaning up comments and adding tests --------- (cherry picked from commit a6ac83a) Signed-off-by: Amit Galitzky <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding multi node IT tests, removed deprovisioning from IT for now until other fixes merge.
Fixed 2 bugs for update API.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.