Fix thread hang in flow framework issue #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zane-neo <[email protected]>
zane-neo
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
=========================================
Coverage 71.83% 71.84%
- Complexity 613 614 +1
=========================================
Files 79 79
Lines 3082 3083 +1
Branches 237 237
=========================================
+ Hits 2214 2215 +1
Misses 763 763
Partials 105 105 ☔ View full report in Codecov by Sentry. |
dbwiddis
approved these changes
Jan 17, 2024
Signed-off-by: Daniel Widdis <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
* Fix hang in flow framework Signed-off-by: zane-neo <[email protected]> * Fix spotless Signed-off-by: Daniel Widdis <[email protected]> * Fix tests to account for async delay Signed-off-by: Daniel Widdis <[email protected]> * Update GHA version for security tests Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: zane-neo <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> Co-authored-by: Daniel Widdis <[email protected]> (cherry picked from commit bf2cad0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
added a commit
that referenced
this pull request
Jan 17, 2024
Fix thread hang in flow framework issue (#413) * Fix hang in flow framework * Fix spotless * Fix tests to account for async delay * Update GHA version for security tests --------- (cherry picked from commit bf2cad0) Signed-off-by: zane-neo <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel Widdis <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When deprovisioning, the thread could be blocked forever and causing cluster status unstable, we need to make the time consuming part to dedicated threadpool to avoid blocking.
Issues Resolved
NA
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.