Search APIs to fetch all the workflows present #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov Report
@@ Coverage Diff @@
## main #139 +/- ##
============================================
+ Coverage 67.58% 67.70% +0.12%
- Complexity 318 330 +12
============================================
Files 38 43 +5
Lines 1490 1539 +49
Branches 140 142 +2
============================================
+ Hits 1007 1042 +35
- Misses 434 448 +14
Partials 49 49
|
owaiskazi19
commented
Nov 1, 2023
src/main/java/org/opensearch/flowframework/rest/AbstractSearchWorkflowAction.java
Show resolved
Hide resolved
joshpalis
reviewed
Nov 1, 2023
src/main/java/org/opensearch/flowframework/rest/AbstractSearchWorkflowAction.java
Show resolved
Hide resolved
Posted the response in the issue. Do you want me to add in the PR as well? |
joshpalis
approved these changes
Nov 3, 2023
|
@owaiskazi19 Perhaps lets merge in #142 first prior to this PR. After rebasing, you can also set this new API behind the feature flag |
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
force-pushed
the
get-api
branch
2 times, most recently
from
8140f81 to
0bdedd2
Compare
Signed-off-by: Owais Kazi <[email protected]>
amitgalitz
reviewed
Nov 7, 2023
src/main/java/org/opensearch/flowframework/rest/AbstractSearchWorkflowAction.java
Show resolved
Hide resolved
amitgalitz
reviewed
Nov 7, 2023
src/main/java/org/opensearch/flowframework/rest/AbstractSearchWorkflowAction.java
Show resolved
Hide resolved
amitgalitz
reviewed
Nov 7, 2023
src/main/java/org/opensearch/flowframework/transport/SearchWorkflowTransportAction.java
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <[email protected]>
amitgalitz
approved these changes
Nov 7, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
* Initial Implementation of Search API Signed-off-by: Owais Kazi <[email protected]> * Added tests Signed-off-by: Owais Kazi <[email protected]> * Added tests for transport action Signed-off-by: Owais Kazi <[email protected]> * Added javadoc Signed-off-by: Owais Kazi <[email protected]> * Set APIs behind the feature flag Signed-off-by: Owais Kazi <[email protected]> * Minor comment Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit dbbff74) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19
pushed a commit
that referenced
this pull request
Nov 7, 2023
Search APIs to fetch all the workflows present (#139) * Initial Implementation of Search API * Added tests * Added tests for transport action * Added javadoc * Set APIs behind the feature flag * Minor comment --------- (cherry picked from commit dbbff74) Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds 2 APIs:
The request and response are present in the issue.
Issues Resolved
Closes #124
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.