Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ProvisionWorkflowTransportAction, handling case in which a document does not exist #100

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Fixing ProvisionWorkflowTransportAction, handling case in which a document does not exist #100

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db4eafa
Fixing bug, handling case in which a GC entry does not exist prior to…
joshpalis Oct 16, 2023
2af5686
Catching topological sorting exceptions when executing the workflow
joshpalis Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/main/java/org/opensearch/flowframework/transport/ProvisionWorkflowTransportAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,16 @@
client.get(getRequest, ActionListener.wrap(response -> {
context.restore();

if (!response.isExists()) {
listener.onFailure(

Check warning on line 88 in src/main/java/org/opensearch/flowframework/transport/ProvisionWorkflowTransportAction.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/opensearch/flowframework/transport/ProvisionWorkflowTransportAction.java#L88 

Added line #L88 was not covered by tests
new FlowFrameworkException(
"Failed to retrieve template (" + workflowId + ") from global context.",
RestStatus.NOT_FOUND
)
);
return;

Check warning on line 94 in src/main/java/org/opensearch/flowframework/transport/ProvisionWorkflowTransportAction.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/opensearch/flowframework/transport/ProvisionWorkflowTransportAction.java#L94 

Added line #L94 was not covered by tests
owaiskazi19 marked this conversation as resolved.
Show resolved Hide resolved
}

// Parse template from document source
Template template = Template.parseFromDocumentSource(response.getSourceAsString());

Expand Down
Loading