Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #111: Build on #113 also address Unable to find file /etc/selinux/config error #122

Closed
wants to merge 4 commits into from
Closed

Fixes #111: Build on #113 also address Unable to find file /etc/selinux/config error #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5fe1e2
Added failed_when in "Disable the selinux" task
FactorT Feb 8, 2023
cddafd6
Added failed_when in "Disable the selinux" task
FactorT Feb 8, 2023
f6c07f8
do not fail for "Unable to find file /etc/selinux/config"
heiderich Mar 18, 2023
c4b2156
do not fail for "Unable to find file /etc/selinux/config"
heiderich Mar 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions roles/linux/dashboards/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
selinux:
state: disabled
when: (ansible_distribution != "Ubuntu") and (ansible_distribution != "Amazon")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heiderich Initially I added when condition to do this task only for OS distribution other than ubuntu and amazon linux where I faced different errors due to unavailable of this module in those distributions.

If this condition covers errors from Ubuntu and amazon distributions then we can remove when completely.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heiderich could you please check the above comments?

register: result
failed_when: result.msg | default('ok', True) is not search('(^ok$|libselinux-python|Unable to find file /etc/selinux/config|(SELinux state changed))')

- name: Populate the nodes to /etc/hosts
import_tasks: etchosts.yml
Expand Down
2 changes: 2 additions & 0 deletions roles/linux/opensearch/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
selinux:
state: disabled
when: (ansible_distribution != "Ubuntu") and (ansible_distribution != "Amazon")
register: result
failed_when: result.msg | default('ok', True) is not search('(^ok$|libselinux-python|Unable to find file /etc/selinux/config|(SELinux state changed))')

- name: Populate the nodes to /etc/hosts
import_tasks: etchosts.yml
Expand Down