Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create query index at the time of monitor creation #1674

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Sep 26, 2024

Description

create query index at the time of monitor creation
continuing #1673

Related Issues

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@eirsep
Copy link
Member

eirsep commented Sep 26, 2024

can we add tests verifying presence of query index and expected mappings?

@sbcd90
Copy link
Collaborator Author

sbcd90 commented Sep 26, 2024

can we add tests verifying presence of query index and expected mappings?

tests are already present verifying presence of query index and expected mappings. This change impacts the dedicated query index workflow. Tests are present in security-analytics to check for exact dynamic query index name as it is the only plugin using this feature. https://github.com/sbcd90/security-analytics/blob/query_idx/src/test/java/org/opensearch/securityanalytics/resthandler/DetectorRestApiIT.java#L1831

@sbcd90 sbcd90 merged commit 5b27d24 into opensearch-project:main Sep 26, 2024
18 of 22 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 26, 2024
Signed-off-by: Subhobrata Dey <[email protected]>
(cherry picked from commit 5b27d24)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.15 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.15
# Create a new branch
git switch --create backport-1674-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5b27d24f765a4bbc3940bb73a1e9a8c526329271
# Push it to GitHub
git push --set-upstream origin backport-1674-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.15

Then, create a pull request where the base branch is 2.15 and the compare/head branch is backport-1674-to-2.15.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.16
# Create a new branch
git switch --create backport-1674-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5b27d24f765a4bbc3940bb73a1e9a8c526329271
# Push it to GitHub
git push --set-upstream origin backport-1674-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport-1674-to-2.16.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.17
# Create a new branch
git switch --create backport-1674-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5b27d24f765a4bbc3940bb73a1e9a8c526329271
# Push it to GitHub
git push --set-upstream origin backport-1674-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport-1674-to-2.17.

sbcd90 added a commit to sbcd90/alerting that referenced this pull request Sep 26, 2024
sbcd90 pushed a commit that referenced this pull request Sep 30, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 30, 2024
Signed-off-by: Subhobrata Dey <[email protected]>
(cherry picked from commit 15518fa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit that referenced this pull request Oct 1, 2024
…1684)

(cherry picked from commit 15518fa)

Signed-off-by: Subhobrata Dey <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sbcd90 pushed a commit to sbcd90/alerting that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants