Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.9] Don't attempt to parse workflow if it doesn't exist #1360

Merged
merged 1 commit into from
Mar 11, 2024
Merged

[Backport 2.9] Don't attempt to parse workflow if it doesn't exist #1360

merged 1 commit into from
Mar 11, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 733fd4e from #1346.

@github-actions
Don't attempt to parse workflow if it doesn't exist (#1346)
e701472 
Signed-off-by: Chase Engelbrecht <[email protected]>
(cherry picked from commit 733fd4e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@engechas
Copy link
Collaborator

Workflows are failing with

> Task :alerting:compileKotlin
e: /Users/engechas/security-analytics/alerting/alerting/src/main/kotlin/org/opensearch/alerting/settings/SupportedClusterMetricsSettings.kt: (90, 35): Unresolved reference: CAT_INDICES
e: /Users/engechas/security-analytics/alerting/alerting/src/main/kotlin/org/opensearch/alerting/settings/SupportedClusterMetricsSettings.kt: (97, 35): Unresolved reference: CAT_SHARDS
e: /Users/engechas/security-analytics/alerting/alerting/src/main/kotlin/org/opensearch/alerting/util/clusterMetricsMonitorHelpers/SupportedClusterMetricsSettingsExtensions.kt: (49, 47): Unresolved reference: CAT_INDICES
e: /Users/engechas/security-analytics/alerting/alerting/src/main/kotlin/org/opensearch/alerting/util/clusterMetricsMonitorHelpers/SupportedClusterMetricsSettingsExtensions.kt: (66, 47): Unresolved reference: CAT_SHARDS
e: /Users/engechas/security-analytics/alerting/alerting/src/main/kotlin/org/opensearch/alerting/util/clusterMetricsMonitorHelpers/SupportedClusterMetricsSettingsExtensions.kt: (115, 107): Unresolved reference: CAT_INDICES
e: /Users/engechas/security-analytics/alerting/alerting/src/main/kotlin/org/opensearch/alerting/util/clusterMetricsMonitorHelpers/SupportedClusterMetricsSettingsExtensions.kt: (119, 107): Unresolved reference: CAT_SHARDS

> Task :alerting:compileKotlin FAILED

I ran ./gradlew :alerting:compileKotlin locally on the 2.9 branch and got the same exception so it is unrelated to this backport.

@riysaxen-amzn
Copy link
Collaborator

all the tests are failing, let's check them

@engechas
Copy link
Collaborator

all the tests are failing, let's check them

The above comment explains why they are failing, it is unrelated to this PR. I will rerun once to see if it has been resolved by now. If not, I will merge and open an issue to track the fix

@engechas
Copy link
Collaborator

all the tests are failing, let's check them

The above comment explains why they are failing, it is unrelated to this PR. I will rerun once to see if it has been resolved by now. If not, I will merge and open an issue to track the fix

Actually it seems that I don't have permission to rerun the jobs. Will validate based on the execution that's kicked off from merging this

@engechas engechas merged commit 8d5bef5 into 2.9 Mar 11, 2024
3 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riysaxen-amzn riysaxen-amzn riysaxen-amzn approved these changes

@engechas engechas engechas approved these changes

Assignees
No one assigned
Labels
autocut
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engechas @riysaxen-amzn