Fix NPE for non-vis embeddables on dashboards (#682) (#683)

(cherry picked from commit 8fcf14c) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-project · Aug 10, 2023 · 3478bba · 3478bba
1 parent 64e4212
commit 3478bba
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/public/actions/alerting_dashboard_action.tsx b/public/actions/alerting_dashboard_action.tsx
@@ -51,12 +51,13 @@ export const createAlertingAction = ({
     getIconType: () => icon,
     type,
     grouping,
-    // Do not show actions for certin visualizations
+    // Do not show actions for certain visualizations
     isCompatible: async ({ embeddable }: ActionContext) => {
       return Boolean(
         embeddable.parent &&
         embeddable.getInput()?.viewMode === 'view' &&
         isDashboard(embeddable.parent) &&
+        embeddable.vis &&
         isEligibleForVisLayers(embeddable.vis, getUISettings())
       );
     },