-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make entries for dependencies from server/build.gradle to gradle version catalog #16707
base: main
Are you sure you want to change the base?
Conversation
…ion catalog Signed-off-by: Craig Perkins <[email protected]>
❌ Gradle check result for 744698c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Craig Perkins <[email protected]>
@@ -79,3 +79,51 @@ resteasy = "6.2.4.Final" | |||
# opentelemetry dependencies | |||
opentelemetry = "1.41.0" | |||
opentelemetrysemconv = "1.27.0-alpha" | |||
|
|||
[libraries] | |||
hdrhistogram = { group = "org.hdrhistogram", name = "HdrHistogram", version.ref = "hdrhistogram" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoiding using hyphens and underscores in library or bundle names that are directly referenced outside this file. When using hyphens and underscores, they need to be changed to . when referenced: gradle/gradle#18050
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16707 +/- ##
============================================
- Coverage 72.12% 72.09% -0.03%
- Complexity 65230 65258 +28
============================================
Files 5318 5318
Lines 303940 303940
Branches 43976 43976
============================================
- Hits 219207 219126 -81
- Misses 66803 66908 +105
+ Partials 17930 17906 -24 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Craig Perkins <[email protected]>
Description
This PR starts to expand on the gradle version catalog by defining the
[libraries]
and[bundles]
section of the version library. This starts to enable dependabot to make automated upgrades of these dependencies and makes managing bundles easier than managing bundles in individual build.gradle files.Related Issues
Follow-up to #16284
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.