Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback on Term-Version check mismatch - backport #16059

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

rajiv-kv
Copy link
Contributor

Description

Backport of https://github.com/opensearch-project/OpenSearch/pull/15424/files to 2.x

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for ee94cd8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 84f5d9a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rajiv-kv
Copy link
Contributor Author

❌ Gradle check result for 84f5d9a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test
14293 15818

Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
Copy link
Contributor

✅ Gradle check result for e2112aa: SUCCESS

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 73.83178% with 28 lines in your changes missing coverage. Please review.

Project coverage is 71.78%. Comparing base (8cf7f92) to head (e2112aa).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...stermanager/TransportClusterManagerNodeAction.java 67.64% 7 Missing and 4 partials ⚠️
...termanager/term/TransportGetTermVersionAction.java 58.33% 2 Missing and 3 partials ⚠️
...rt/clustermanager/term/GetTermVersionResponse.java 72.72% 1 Missing and 2 partials ⚠️
...arch/gateway/remote/RemoteClusterStateService.java 72.72% 1 Missing and 2 partials ⚠️
...ensearch/gateway/remote/RemoteManifestManager.java 62.50% 2 Missing and 1 partial ⚠️
...g/opensearch/cluster/coordination/Coordinator.java 50.00% 1 Missing and 1 partial ⚠️
...search/gateway/remote/RemoteClusterStateCache.java 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16059      +/-   ##
============================================
+ Coverage     71.68%   71.78%   +0.09%     
- Complexity    64650    64755     +105     
============================================
  Files          5277     5278       +1     
  Lines        302465   302568     +103     
  Branches      43998    44013      +15     
============================================
+ Hits         216831   217202     +371     
+ Misses        67525    67218     -307     
- Partials      18109    18148      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwetathareja shwetathareja merged commit 8c6ca69 into opensearch-project:2.x Sep 24, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants