-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for RemoteGlobalMetadataManager #14394
Add tests for RemoteGlobalMetadataManager #14394
Conversation
Signed-off-by: Shivansh Arora <[email protected]>
c0a12f2
to
587c566
Compare
❕ Gradle check result for c0a12f2: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14394 +/- ##
============================================
+ Coverage 71.42% 71.77% +0.35%
- Complexity 59978 62099 +2121
============================================
Files 4985 5118 +133
Lines 282275 291833 +9558
Branches 40946 42180 +1234
============================================
+ Hits 201603 209456 +7853
- Misses 63999 65066 +1067
- Partials 16673 17311 +638 ☔ View full report in Codecov by Sentry. |
❌ Gradle check result for 587c566: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/test/java/org/opensearch/gateway/remote/RemoteGlobalMetadataManagerTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Shivansh Arora <[email protected]>
3aefbed
to
ec042aa
Compare
server/src/test/java/org/opensearch/gateway/remote/RemoteStateTestUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Shivansh Arora <[email protected]>
❌ Gradle check result for 5924b92: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shivansh Arora <[email protected]>
❌ Gradle check result for b456243: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for b456243: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
* Add tests for RemoteGlobalMetadataManager Signed-off-by: Shivansh Arora <[email protected]> * Add TestCapturingListener Signed-off-by: Shivansh Arora <[email protected]> * Move TestCapturingListener to test/framework Signed-off-by: Shivansh Arora <[email protected]> * Added javadoc Signed-off-by: Shivansh Arora <[email protected]> --------- Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit 8e32ed7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add tests for RemoteGlobalMetadataManager * Add TestCapturingListener * Move TestCapturingListener to test/framework * Added javadoc --------- (cherry picked from commit 8e32ed7) Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add tests for RemoteGlobalMetadataManager Signed-off-by: Shivansh Arora <[email protected]> * Add TestCapturingListener Signed-off-by: Shivansh Arora <[email protected]> * Move TestCapturingListener to test/framework Signed-off-by: Shivansh Arora <[email protected]> * Added javadoc Signed-off-by: Shivansh Arora <[email protected]> --------- Signed-off-by: Shivansh Arora <[email protected]>
…pensearch-project#14458) * Add tests for RemoteGlobalMetadataManager * Add TestCapturingListener * Move TestCapturingListener to test/framework * Added javadoc --------- (cherry picked from commit 8e32ed7) Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <[email protected]>
* Add tests for RemoteGlobalMetadataManager Signed-off-by: Shivansh Arora <[email protected]> * Add TestCapturingListener Signed-off-by: Shivansh Arora <[email protected]> * Move TestCapturingListener to test/framework Signed-off-by: Shivansh Arora <[email protected]> * Added javadoc Signed-off-by: Shivansh Arora <[email protected]> --------- Signed-off-by: Shivansh Arora <[email protected]>
Description
Add tests for async read and write of attributes in
RemoteGlobalMetadataManager
. These flows were added in #14089, #13924 but coverage for these flows were not sufficient.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.