-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support imports without extensions in cypress webpack build #8993
fix: support imports without extensions in cypress webpack build #8993
Conversation
Signed-off-by: Daniel Rowe <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## cypress-unification #8993 +/- ##
======================================================
Coverage ? 60.87%
======================================================
Files ? 3802
Lines ? 91070
Branches ? 14374
======================================================
Hits ? 55443
Misses ? 32086
Partials ? 3541
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Rowe <[email protected]>
Signed-off-by: Daniel Rowe <[email protected]>
Related: #4813 |
This isolation was causing regressions Signed-off-by: Daniel Rowe <[email protected]>
c6f5c8f
into
opensearch-project:cypress-unification
I don't think we need AGGREGATION_VIEW: false and ML_COMMONS_DASHBOARDS_ENABLED: true but I also don't think it is hurtful. But can clean up in a follow-up if we need a more cleaned up config file. |
…nsearch-project#8993) * fix: support imports without extensions in cypress webpack build Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR opensearch-project#8993 created/updated * use typescript config Signed-off-by: Daniel Rowe <[email protected]> * fix lint Signed-off-by: Daniel Rowe <[email protected]> * disable new test isolation feature This isolation was causing regressions Signed-off-by: Daniel Rowe <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* Update Cypress to v12 (#8926) * Update cypress to v12 Signed-off-by: Daniel Rowe <[email protected]> * Add required e2e.js Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR #8926 created/updated * Update license header Signed-off-by: Daniel Rowe <[email protected]> * Update license in e2e.js Signed-off-by: Daniel Rowe <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix: support imports without extensions in cypress webpack build (#8993) * fix: support imports without extensions in cypress webpack build Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR #8993 created/updated * use typescript config Signed-off-by: Daniel Rowe <[email protected]> * fix lint Signed-off-by: Daniel Rowe <[email protected]> * disable new test isolation feature This isolation was causing regressions Signed-off-by: Daniel Rowe <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
When migrating to cypress v12, we saw a small number of regressions due compilation failures in cypress. This change is to resolve this class of issue. Once resolved in this branch I'll create a PR to merge the cypress 12 upgrade in main.
Details
By default, cypress' internal webpack preprocessor doesn't allow imports without file extensions. This makes our life a bit hard since if any file in our testing dependency graph has an import without the .js extension our cypress build will fail.
This configuration relaxes this a bit by allowing imports without file extension
ex. import module from './module'
Changelog
Check List
yarn test:jest
yarn test:jest_integration