[Backport 2.x] [Workspace] Add workspaceAvailability field into application #6628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* [Workspace] Jump to non-workspace url when clicking home icon (#316) * temp: save Signed-off-by: SuZhou-Joe <[email protected]> * feat: complete the feature Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless code Signed-off-by: SuZhou-Joe <[email protected]> * fix: bootstrap error Signed-off-by: SuZhou-Joe <[email protected]> * fix: bootstrap error Signed-off-by: SuZhou-Joe <[email protected]> * fix: page not found error Signed-off-by: SuZhou-Joe <[email protected]> * fix: anchor href Signed-off-by: SuZhou-Joe <[email protected]> * feat: update toNavLink to comply with workspace Signed-off-by: SuZhou-Joe <[email protected]> * feat: change to workspaceless Signed-off-by: SuZhou-Joe <[email protected]> * feat: change to workspaceless Signed-off-by: SuZhou-Joe <[email protected]> * feat: change to workspaceless Signed-off-by: SuZhou-Joe <[email protected]> * feat: register list and create page as workspaceless Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize code Signed-off-by: SuZhou-Joe <[email protected]> * feat: update to WorkspaceVisibility Signed-off-by: SuZhou-Joe <[email protected]> * feat: add unit test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize the jump logic Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test Signed-off-by: SuZhou-Joe <[email protected]> * feat: make app inaccessible if workspaceAccessibility is No Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> * refactor: using WorkspaceAvailability Signed-off-by: SuZhou-Joe <[email protected]> * feat: change test name Signed-off-by: SuZhou-Joe <[email protected]> * feat: update wording Signed-off-by: SuZhou-Joe <[email protected]> * feat: update test Signed-off-by: SuZhou-Joe <[email protected]> * feat: add unit test Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove CHANGELOG change Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #6427 created/updated * Apply suggestions from code review Co-authored-by: Yulong Ruan <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> * Update src/plugins/workspace/public/utils.test.ts Co-authored-by: Miki <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> * Lint src/plugins/workspace/public/utils.test.ts Signed-off-by: Miki <[email protected]> * Lint src/plugins/workspace/public/utils.test.ts Signed-off-by: Miki <[email protected]> * Lint src/plugins/workspace/public/utils.test.ts Signed-off-by: Miki <[email protected]> * fix: lint error Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit 104ee42) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
SuZhou-Joe
approved these changes
Apr 24, 2024
ruanyl
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 104ee42 from #6427.