[Workspace] Delete saved objects by workspace

[Hailong-am]

Description

Add delete saved objects by workspace functionality. When delete workspace we need delete all saved objects under this workspace.

Issues Resolved

Partial of #4944
Closes #6016

Screenshot

Testing the changes

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.12%. Comparing base (8f0885d) to head (2f3418c).
Report is 613 commits behind head on main.

Files with missing lines	Patch %	Lines
...rver/saved_objects/service/saved_objects_client.ts	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6013      +/-   ##
==========================================
- Coverage   67.14%   67.12%   -0.02%     
==========================================
  Files        3324     3324              
  Lines       64309    64318       +9     
  Branches    10341    10344       +3     
==========================================
- Hits        43182    43176       -6     
- Misses      18604    18618      +14     
- Partials     2523     2524       +1     

Flag	Coverage Δ
Linux_1	31.66% <0.00%> (-0.01%)	⬇️
Linux_2	55.23% <88.88%> (+0.01%)	⬆️
Linux_3	44.70% <0.00%> (-0.01%)	⬇️
Linux_4	35.08% <11.11%> (-0.01%)	⬇️
Windows_1	31.68% <0.00%> (-0.04%)	⬇️
Windows_2	55.20% <88.88%> (+0.01%)	⬆️
Windows_3	44.70% <0.00%> (-0.02%)	⬇️
Windows_4	35.08% <11.11%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SuZhou-Joe]

A quick question that it seems all the changes are happening on server side, will we add a new public method like deleteByWorkspace in public/workspace.client?

[Hailong-am]

A quick question that it seems all the changes are happening on server side, will we add a new public method like deleteByWorkspace in public/workspace.client?

No, this's part of delete workspace logic at server side. There will have a public method delete in public/workspaceClient which will call delete method at server side.

[ZilongX]

Is it taking the workspace name or id as the param ?

[ZilongX]

if it's actually taking the id maybe let's try to name like workspaceId or add the detail in the comment

[Hailong-am]

make sense. As we are using workspace everywhere to reference as its id, to make the name consistent, let me add this to parameter comment.

[Hailong-am]

link check failed due to http://fakenews.co/opensearch-dashboards-test/v6.8.2.json is not reachable in this file src/plugins/newsfeed/public/lib/api.test.ts

Errors in src/plugins/newsfeed/public/lib/api.test.ts
+ echo
+ echo ::set-output name=exit_code::2
✗ http://fakenews.co/opensearch-dashboards-test/v6.8.2.json (error sending request for url (http://fakenews.co/opensearch-dashboards-test/v6.8.2.json): connection closed before message completed)
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/```

[SuZhou-Joe]

Nit: useless empty line

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6013-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 735424bcaabfc752453c4d514ddd5d4b4f1b6d6d
# Push it to GitHub
git push --set-upstream origin backport/backport-6013-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6013-to-2.x.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6013-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 735424bcaabfc752453c4d514ddd5d4b4f1b6d6d
# Push it to GitHub
git push --set-upstream origin backport/backport-6013-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6013-to-2.x.