Skip to content

Commit

Permalink
merge main
Browse files Browse the repository at this point in the history
Signed-off-by: Hailong Cui <[email protected]>
  • Loading branch information
Hailong-am committed Mar 21, 2024
1 parent 380cb37 commit bcea4b4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/plugins/workspace/public/plugin.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ describe('Workspace plugin', () => {
const workspacePlugin = new WorkspacePlugin();
const setupMock = getSetupMock();
const coreStart = coreMock.createStart();
await workspacePlugin.setup(setupMock);
await workspacePlugin.setup(setupMock, {});
workspacePlugin.start(coreStart);
coreStart.workspaces.currentWorkspaceId$.next('foo');
expect(coreStart.savedObjects.client.setCurrentWorkspace).toHaveBeenCalledWith('foo');
Expand Down Expand Up @@ -73,7 +73,7 @@ describe('Workspace plugin', () => {
});

const workspacePlugin = new WorkspacePlugin();
await workspacePlugin.setup(setupMock);
await workspacePlugin.setup(setupMock, {});
expect(setupMock.application.register).toBeCalledTimes(1);
expect(WorkspaceClientMock).toBeCalledTimes(1);
expect(workspaceClientMock.enterWorkspace).toBeCalledWith('workspaceId');
Expand Down Expand Up @@ -127,7 +127,7 @@ describe('Workspace plugin', () => {
});

const workspacePlugin = new WorkspacePlugin();
await workspacePlugin.setup(setupMock);
await workspacePlugin.setup(setupMock, {});
currentAppIdSubscriber?.next(WORKSPACE_FATAL_ERROR_APP_ID);
expect(applicationStartMock.navigateToApp).toBeCalledWith(WORKSPACE_OVERVIEW_APP_ID);
windowSpy.mockRestore();
Expand All @@ -136,7 +136,7 @@ describe('Workspace plugin', () => {
it('#setup register workspace dropdown menu when setup', async () => {
const setupMock = coreMock.createSetup();
const workspacePlugin = new WorkspacePlugin();
await workspacePlugin.setup(setupMock);
await workspacePlugin.setup(setupMock, {});
expect(setupMock.chrome.registerCollapsibleNavHeader).toBeCalledTimes(1);
});
});
1 change: 1 addition & 0 deletions src/plugins/workspace/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { Services } from './types';
import { WorkspaceClient } from './workspace_client';
import { SavedObjectsManagementPluginSetup } from '../../../plugins/saved_objects_management/public';
import { WorkspaceMenu } from './components/workspace_menu/workspace_menu';
import { getWorkspaceColumn } from './components/workspace_column';

type WorkspaceAppType = (params: AppMountParameters, services: Services) => () => void;

Expand Down

0 comments on commit bcea4b4

Please sign in to comment.