Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Yulong Ruan <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
  • Loading branch information
SuZhou-Joe and ruanyl authored Apr 19, 2024
1 parent 90e4820 commit 84760ea
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/core/public/application/application_service.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ describe('#start()', () => {
`);
});

it('navigate by using window.location.assign if navigate to a app not accessible within a workspace', async () => {
it('refresh the page if navigate to a app not accessible within a workspace', async () => {
// Save the original assign method
const originalLocation = window.location;
delete (window as any).location;
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/workspace/public/utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ describe('workspace utils: isAppAccessibleInWorkspace', () => {
).toBe(true);
});

it('An app is not accessible if its workspaceAvailability is outsideWorkspace', () => {
it('An app is not accessible within a workspace if its workspaceAvailability is outsideWorkspace', () => {
expect(
isAppAccessibleInWorkspace(
{
Expand Down

0 comments on commit 84760ea

Please sign in to comment.