Cache Overhaul for OpenSeadragon (reviewed). #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
iangilman
reviewed
Nov 26, 2024
There was a problem hiding this comment.
This is awesome! Thank you for putting all of this documentation together.
There are some places where there are some English grammatical oddities... Your English is excellent, but still there are some things I would change to make it read more smoothly. Perhaps I should do an editing pass to touch up some of those… seems easier than pointing them all out via review. What do you think?
Feel free to edit any content. I am well aware I have problems to come up with easily understandable text 😄 |
…e description. Rename everywhere docs page data-plugins -> data-modification.
|
Cool; I'll do a pass on this at some point. Otherwise I think it's good to go. We won't merge it until we release 6.0.0, of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for openseadragon/openseadragon#2407