Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL safe encoding #49

Merged
merged 6 commits into from
Nov 26, 2024
Merged

URL safe encoding #49

merged 6 commits into from
Nov 26, 2024

Conversation

F-Shahali
Copy link
Collaborator

Reference Issues/PRs

#48

What does this implement/fix? Explain your changes.

  • Add an option for URL-safe encoding (using Base64 format) in indirect sharing mode, and handle it with the encoded query parameter.

Any other comments?

@F-Shahali F-Shahali added this to the mybutton v0.4 milestone Nov 17, 2024
@F-Shahali F-Shahali self-assigned this Nov 17, 2024
@F-Shahali F-Shahali marked this pull request as ready for review November 17, 2024 20:31
@F-Shahali F-Shahali marked this pull request as draft November 18, 2024 16:50
@F-Shahali F-Shahali marked this pull request as ready for review November 18, 2024 17:06
Copy link
Member

@AHReccese AHReccese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job dear Fatemeh, I talked with Sepand and I think it would be better to have additional (cause we already apply percent encoding (which is an encoding) to the given url) encoding selection similar to a radio group with the exact encoding name for example Base64 (more robust) for now.

This radio group (or single select checkboxes) could appear next to the direct indirect box after selecting indirect case, or maybe under the direct | indirect box.

Also there should be None checkbox to remove additional encoding selection (or the checkbox could be de-selectable).

Thanks.

@F-Shahali
Copy link
Collaborator Author

Great job dear Fatemeh, I talked with Sepand and I think it would be better to have additional (cause we already apply percent encoding (which is an encoding) to the given url) encoding selection similar to a radio group with the exact encoding name for example Base64 (more robust) for now.

This radio group (or single select checkboxes) could appear next to the direct indirect box after selecting indirect case, or maybe under the direct | indirect box.

Also there should be None checkbox to remove additional encoding selection (or the checkbox could be de-selectable).

Thanks.

Thanks for your good suggestion, yeah it sounds better.
Ok, I'll do the same.

@AHReccese AHReccese merged commit 58da2df into dev Nov 26, 2024
3 checks passed
@AHReccese AHReccese deleted the url_safe_encoding branch November 26, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants