-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL safe encoding #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job dear Fatemeh, I talked with Sepand and I think it would be better to have additional (cause we already apply percent encoding (which is an encoding) to the given url) encoding selection similar to a radio group with the exact encoding name for example Base64 (more robust)
for now.
This radio group (or single select checkboxes) could appear next to the direct indirect box after selecting indirect case, or maybe under the direct | indirect box.
Also there should be None checkbox to remove additional encoding selection (or the checkbox could be de-selectable).
Thanks.
Thanks for your good suggestion, yeah it sounds better. |
Reference Issues/PRs
#48
What does this implement/fix? Explain your changes.
Base64
format) in indirect sharing mode, and handle it with theencoded
query parameter.Any other comments?