Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Strictly speaking, the links weren't broken. However, there's a really weird intersection of GitHub and lychee's behaviour here. Two behavioural points to explain. First, GitHub seems to tend to give different response behaviour for repository redirects, depending on whether the client is a full web browser or not (my best guess; typically requests to these kinds of redirects give a 404 via `wget` and `curl`, but maybe sometimes not?). This behaviour may have changed recently, unless these repositories have been renamed recently (and I don't believe that to be true). Second, lychee is one of these clients affected by this behaviour. So what happens when the link check fails: 1. The lychee action runs and lychee checks a repository URL that is going to get redirected. 1. GitHub's servers now give a 404 for that URL-to-be-redirected. 1. lychee notes down in the raw logs that the URL included in the documentation source is a 404. 1. The GitHub Actions summary of the action run gives a Markdown formatted output. 1. That output has the repository redirect URL updated to the new URL for the redirection in the formatted output, magically by GitHub. **The new URL never appeared in the logs at all!** 1. **The link works in browser in any case**, partly because this is the new URL, and it would even for the original non-redirected URL, because these still work in browser. So it's very confusing that it's labelled as `404`.
- Loading branch information