Allow orgs with leading numbers in name in GitRemote #4727
Conversation
|
You're welcome! You did just miss the release we did today, but I imagine you're comfortable running snapshot versions if needed. All the best! |
| @@ -279,7 +279,7 @@ private String repositoryPath(RemoteServerMatch match, URI normalizedUri) { | |||
| .replaceFirst("^/", ""); | |||
| } | |||
|
|
|||
| private static final Pattern PORT_PATTERN = Pattern.compile(":\\d+"); | |||
| private static final Pattern PORT_PATTERN = Pattern.compile(":\\d+[^-\\w]"); // Allow orgs with numbers in name | |||
There was a problem hiding this comment.
github at least supports org names with only numbers.
There was a problem hiding this comment.
Guess those will still get the exception thrown then, but at least this works for partial numeric org names. Welcome suggestions for a complete fix!
There was a problem hiding this comment.
Guess those will still get the exception thrown then, but at least this works for partial numeric org names. Welcome suggestions for a complete fix!
I had opened this previously #4651
There was a problem hiding this comment.
Ah, I had no idea. Approved just now & sorry about the conflict. Do let me know if there's ever something open for too long.
What's your motivation?
Anyone you would like to review specifically?
@tylervangorder-8451