Exclude omitted dependencies as well through a second cycle #4724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Run a second cycle of ExcludeDependency when the document has changed, to also exclude previously omitted dependencies.
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Second cycle might require changes in the future, but at that point we're more free to change the model as well, as seen in:
Anyone you would like to review specifically?
@SiBorea @ckcd
Credits for the test here go to @ckcd 🙏🏻
Have you considered any alternatives or workarounds?
We can change the model as seen in this work
But that would then need careful consideration to account for serialization, and we'd be doing so for a single use case here.