Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude omitted dependencies as well through a second cycle #4724

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

timtebeek
Copy link
Contributor

@timtebeek timtebeek commented Nov 27, 2024

What's changed?

Run a second cycle of ExcludeDependency when the document has changed, to also exclude previously omitted dependencies.

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Second cycle might require changes in the future, but at that point we're more free to change the model as well, as seen in:

Anyone you would like to review specifically?

@SiBorea @ckcd

Credits for the test here go to @ckcd 🙏🏻

Have you considered any alternatives or workarounds?

We can change the model as seen in this work

But that would then need careful consideration to account for serialization, and we'd be doing so for a single use case here.

@timtebeek timtebeek added the enhancement New feature or request label Nov 27, 2024
@timtebeek timtebeek self-assigned this Nov 27, 2024
@timtebeek timtebeek mentioned this pull request Nov 27, 2024
3 tasks
@timtebeek timtebeek merged commit 6bb23d4 into main Nov 27, 2024
2 checks passed
@timtebeek timtebeek deleted the exclude-omitted-dependencies-as-well branch November 27, 2024 12:38
@ckcd
Copy link
Contributor

ckcd commented Nov 27, 2024

@timtebeek Thanks for your deep check and fix! Nice to see the issue fixed. That's really a helpful recipe for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants