Add a new recipe to add comments to a Java method #4719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
agoncal
commented
Nov 26, 2024
•
agoncal
commented
- Fixes Add a new recipe to add comments to a Java method #4716
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-java/src/main/java/org/openrewrite/java/AddCommentToMethod.java
Outdated
Show resolved
Hide resolved
rewrite-java/src/test/java/org/openrewrite/java/AddCommentToMethodTest.java
Show resolved
Hide resolved
rewrite-java/src/test/java/org/openrewrite/java/AddCommentToMethodTest.java
Outdated
Show resolved
Hide resolved
|
@timtebeek I have disabled two tests that are failing because of a strange issue. What shall I do with those tests? |
…thodTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rewrite-java/src/main/java/org/openrewrite/java/AddCommentToMethod.java
Outdated
Show resolved
Hide resolved
rewrite-java/src/test/java/org/openrewrite/java/AddCommentToMethodTest.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
@timtebeek I have disabled two tests that are failing because of a strange issue. What shall I do with those tests?
No worries; I was able to get them going in 7b17b02 . With that I think we're good to merge, thanks!
|
Also handled an additional edge case for comments that contain new lines just to be safe. Hope you agree with the choice there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.