Make Groovy Parser correctly handle nested parenthesis #4718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevanlingen
force-pushed
the
4703-groovy-parser-does-not-correctly-handle-nested-parenthesis
branch
from
8579420
to
378fe5b
Compare
jevanlingen
commented
Nov 26, 2024
| @@ -1664,9 +1667,13 @@ public void visitMethodCallExpression(MethodCallExpression call) { | |||
| Expression selectExpr = visit(call.getObjectExpression()); | |||
There was a problem hiding this comment.
I did some changes below this line, but I have the feeling I am at the wrong track. For instance with following groovy code:
(map.get("foo")).equals("bar")`I can retrieve here an expression that looks printed like (map.get("foo"). I think you would expect it evenly distributed like (map.get("foo")). So maybe that's what should be changed instead of the code here below.
There was a problem hiding this comment.
I stop working on this for now. I can't wrap my head around how the parentheses are set. I probably need a little bit more experience before I start working on parser code 😇.
jevanlingen
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jevanlingen
force-pushed
the
4703-groovy-parser-does-not-correctly-handle-nested-parenthesis
branch
from
bc3b03b
to
fe98f02
Compare
jevanlingen
force-pushed
the
4703-groovy-parser-does-not-correctly-handle-nested-parenthesis
branch
from
fe98f02
to
b7e03e9
Compare
jevanlingen
force-pushed
the
4703-groovy-parser-does-not-correctly-handle-nested-parenthesis
branch
from
5c22da6
to
fe378e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Nested parentheses are supported as well for the groovy parser.
What's your motivation?
Checklist