Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip project dependencies in UpgradeDependencyVersion recipe #4717

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

knutwannheden
Copy link
Contributor

Project dependencies don't take a GAV as an argument and could cause an exception to be thrown by DependencyStringNotationConverter#assignValue() if interpreted as GAVs.

Project dependencies don't take a GAV as an argument and could cause an exception to be thrown by `DependencyStringNotationConverter#assignValue()` if interpreted as GAVs.
@knutwannheden
Copy link
Contributor Author

knutwannheden commented Nov 26, 2024

@shanman190 I didn't know / look if there are other recipes which need to be modified in a similar way. I found this problem in the recipe results for a Spring project.

@knutwannheden knutwannheden merged commit 9bccd2b into main Nov 26, 2024
2 checks passed
@knutwannheden knutwannheden deleted the dont-upgrade-project-dependency branch November 26, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants