Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Determine SCM and parse clone url in GitProvenance for more accurate path/origin/organiation/groups #4367
feat: Determine SCM and parse clone url in GitProvenance for more accurate path/origin/organiation/groups #4367
Changes from 21 commits
f21f282
9774c15
973bed5
6e937cf
e30b193
4fd0365
9fd2b07
b331cef
3d5d541
cbb7a1a
453566b
4c2387c
4fef5be
aacea53
c2e9e9c
5fe218a
4fefa63
ce49346
5dec1dd
8d07e18
43d7957
a13a68a
f408a35
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's necessary to deprecate since it is in widespread use. Fine to have a convenience method for organization on
CloneUrl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually I think we should point back to the "old" method that does not take an argument, and deprecate this one which (again) takes the origin (with scheme).