Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GitProvenance support for Azure DevOps repositories #4364

Closed
wants to merge 4 commits into from

Conversation

bryceatmoderne
Copy link
Contributor

What's changed?

Updated GitProvenance to support parsing Azure DevOps repositories.

What's your motivation?

These changes are required to support Azure DevOps as an SCM.

Anything in particular you'd like reviewers to focus on?

Let me know of other rewrite classes that may require similar updates.

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

No.

Any additional context

No.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@bryceatmoderne bryceatmoderne self-assigned this Jul 30, 2024
@bryceatmoderne bryceatmoderne marked this pull request as draft July 30, 2024 14:40
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-gradle/src/main/groovy/RewriteSettings.groovy
    • lines 31-36

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has always been a bit of an oddity; especially the long deprecated but never fully removed getOrganizationName(). Thanks for extending it thoughtfully.

@bryceatmoderne
Copy link
Contributor Author

This requirement was addressed by #4381

@bryceatmoderne bryceatmoderne deleted the git-provenance-azure-devops-support branch August 7, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants