Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save identified type on cache for future lookups on ChangeType. #4039

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

ammachado
Copy link
Contributor

What's changed?

Types identified as fully-qualified are saved on the internal cache in ChangeTypeVisitor

What's your motivation?

This was identified while debugging #4030

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

No

Have you considered any alternatives or workarounds?

No

Any additional context

No

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek added the bug Something isn't working label Feb 23, 2024
@ammachado ammachado added enhancement New feature or request and removed bug Something isn't working labels Feb 24, 2024
@timtebeek timtebeek self-requested a review February 24, 2024 11:11
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks once again!

@timtebeek timtebeek merged commit 48c2183 into main Feb 24, 2024
1 check failed
@timtebeek timtebeek deleted the change-type-optimization branch February 24, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants