Let UsesMethod add its own marker
#4035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`org.openrewrite.java.search.HasJavaVersion` combined with `org.openrewrite.java.search.FindMethods` fails to find results for FindMethods if that recipe is running after `HasJavaVersion`.
…-java-version-combined-with-find-method
knutwannheden
changed the title
HasJavaVersion combined with FindMethods depends on orderFindMethods add its own marker
knutwannheden
changed the title
FindMethods add its own markerUsesMethod add its own marker
knutwannheden
deleted the
fix/find-java-version-combined-with-find-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
FindMethodsis used on a source file that already has aSearchResultmarker on the root node (as e.g. added byHasJavaVersion) then the recipe will not find anything, because itsUsesMethodprecondition evaluates tofalse(because the root node already has aSearchResultmarker).To avoid this aliasing issue and also avoid issues if
UsesMethodis applied before another recipe / visitor that adds aSearchResultmarker, theUsesMethodvisitor now uses its own marker type. The marker will only be added if the source file doesn't already have a marker which was created for the same method pattern.