Add repository results standard data table #3995
Conversation
| } | ||
| } | ||
|
|
||
| public static String serializeOption(String name, Object value) { |
There was a problem hiding this comment.
doubting between this more readable serialization or json (makes matching a lot easier)
There was a problem hiding this comment.
Wouldn't JSON basically be the same? Now you would get something like:
[foo="false", bar="1", baz="null", qux=`Foo"bar"`]
with JSON:
{"foo":false, "bar":1, "baz":null, "qux":"Foo\"bar\""}Of these I think JSON looks better and it also preserves basic data types and can again be deserialized as JSON.
Of course there will be some additional escaping when serialized as CSV. But that applies to both formats.
| @@ -0,0 +1,128 @@ | |||
| /* | |||
| * Copyright 2022 the original author or authors. | |||
There was a problem hiding this comment.
| * Copyright 2022 the original author or authors. | |
| * Copyright 2024 the original author or authors. |
| } | ||
| } | ||
|
|
||
| public static String serializeOption(String name, Object value) { |
There was a problem hiding this comment.
Wouldn't JSON basically be the same? Now you would get something like:
[foo="false", bar="1", baz="null", qux=`Foo"bar"`]
with JSON:
{"foo":false, "bar":1, "baz":null, "qux":"Foo\"bar\""}Of these I think JSON looks better and it also preserves basic data types and can again be deserialized as JSON.
Of course there will be some additional escaping when serialized as CSV. But that applies to both formats.
| @@ -0,0 +1,71 @@ | |||
| /* | |||
| * Copyright 2023 the original author or authors. | |||
There was a problem hiding this comment.
| * Copyright 2023 the original author or authors. | |
| * Copyright 2024 the original author or authors. |
…esults-standard-data-table
What's changed?
A new standard data table is added (will be created for all recipes)
What's your motivation?
The
SourcesFileResultsdata table is too detailed on the one hand but lacks precision on the other. This data-table makes it possible to uniquely identify a recipe running on a repository and retrieve the aggregated occurrences and estimated time savings.Anything in particular you'd like reviewers to focus on?
Naming, I had my doubts about the data-table name other canididates are:
RecipeResultsRecipeRepositoryResultsAnyone you would like to review specifically?
@jkschneider
Have you considered any alternatives or workarounds?
An alternative would be to fix the
SourcesFileResultsdata table to have the options (or a unique way to identify which results belong to which recipe + options in a list of recipes)Checklist