Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate FindAndReplace No group with name {name} #3387

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

timtebeek
Copy link
Contributor

What's changed?

Added a test to replicate a bug; not yet a fix.

What's your motivation?

Replicate a bug reported with FindAndReplace around find strings containing {..}.

Anything in particular you'd like reviewers to focus on?

Suggestions for a fix welcome.

Anyone you would like to review specifically?

@jdelobel

Have you considered any alternatives or workarounds?

Not yet.

Any additional context

Reported in #3377 (comment)

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ auto-formatter on affected files
  • I've updated the documentation (if applicable)

@timtebeek timtebeek added the bug Something isn't working label Jun 30, 2023
@timtebeek timtebeek self-assigned this Jun 30, 2023
@timtebeek timtebeek removed their assignment Jul 24, 2023
@philippe-granet
Copy link
Contributor

I have the same problem and it works if I escape dollar sign (\\${...})

@timtebeek
Copy link
Contributor Author

That works indeed; thanks! This one had slipped my mind after capturing it from a Slack thread. Just today we saw the same fix in;

@timtebeek timtebeek self-assigned this Nov 17, 2023
@timtebeek timtebeek marked this pull request as ready for review November 17, 2023 21:58
@timtebeek timtebeek requested a review from joanvr November 17, 2023 21:58
Co-authored-by: Joan Viladrosa <[email protected]>
@joanvr joanvr merged commit 31d9eaa into main Nov 20, 2023
1 check passed
@joanvr joanvr deleted the tim/FindAndReplace_no_group_with_name branch November 20, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants