Flip equals to prevent NPE for nullable plugin.groupId

openrewrite · Feb 26, 2024 · 4c176e2 · 4c176e2
1 parent 52454c4
commit 4c176e2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/rewrite-maven/src/main/java/org/openrewrite/maven/RemoveRedundantDependencyVersions.java b/rewrite-maven/src/main/java/org/openrewrite/maven/RemoveRedundantDependencyVersions.java
@@ -173,9 +173,9 @@ && matchesGlob(d.getArtifactId(), exceptedArtifactId)) {
     }
 
     @Nullable
-    private static String getManagedPluginVersion(ResolvedPom resolvedPom, String groupId, String artifactId) {
+    private static String getManagedPluginVersion(ResolvedPom resolvedPom, @Nullable String groupId, String artifactId) {
         for (Plugin p : resolvedPom.getPluginManagement()) {
-            if (groupId.equals(p.getGroupId()) && artifactId.equals(p.getArtifactId())) {
+            if (p.getGroupId().equals(groupId) && p.getArtifactId().equals(artifactId)) {
                 return resolvedPom.getValue(p.getVersion());
             }
         }