Allow for deserialized JavaType.Unknown instances

These can't be compared with referential equality against `JavaType.Unknown.getInstance()`.
openrewrite · Oct 31, 2023 · 289e809 · 289e809
1 parent 15ecf02
commit 289e809
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/...ite-java/src/main/java/org/openrewrite/java/internal/DefaultJavaTypeSignatureBuilder.java b/...ite-java/src/main/java/org/openrewrite/java/internal/DefaultJavaTypeSignatureBuilder.java
@@ -30,7 +30,7 @@ public class DefaultJavaTypeSignatureBuilder implements JavaTypeSignatureBuilder
 
     @Override
     public String signature(@Nullable Object type) {
-        if (type == null || type == JavaType.Unknown.getInstance()) {
+        if (type == null || type instanceof JavaType.Unknown) {
             return "{undefined}";
         }
 

diff --git a/rewrite-java/src/main/java/org/openrewrite/java/tree/TypeUtils.java b/rewrite-java/src/main/java/org/openrewrite/java/tree/TypeUtils.java
@@ -381,10 +381,7 @@ public static JavaType.Primitive asPrimitive(@Nullable JavaType type) {
 
     @Nullable
     public static JavaType.FullyQualified asFullyQualified(@Nullable JavaType type) {
-        if (type instanceof JavaType.FullyQualified) {
-            if (type == JavaType.Unknown.getInstance()) {
-                return null;
-            }
+        if (type instanceof JavaType.FullyQualified && !(type instanceof JavaType.Unknown)) {
             return (JavaType.FullyQualified) type;
         }
         return null;