Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AssertJ dependency if using Hamcrest #648

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

timtebeek
Copy link
Contributor

What's changed?

Flipped around when we add the dependency, as we saw it needlessly added, and to the wrong Gradle configuration.

@timtebeek timtebeek added the bug Something isn't working label Dec 4, 2024
@timtebeek timtebeek self-assigned this Dec 4, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/java/testing/hamcrest/MigrateHamcrestToAssertJTest.java
    • lines 39-40

@timtebeek timtebeek merged commit 433685e into main Dec 4, 2024
2 checks passed
@timtebeek timtebeek deleted the add-assertj-dependency-if-using-hamcrest branch December 4, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants