-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for DbRider migration from junit4 to junit5 #627
Conversation
Jenson3210
commented
Oct 31, 2024
•
edited by timtebeek
Loading
edited by timtebeek
- fixes DBRider support #624
src/main/java/org/openrewrite/java/testing/dbrider/ExecutionListenerToDbRiderAnnotation.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/testing/dbrider/ExecutionListenerToDbRiderAnnotation.java
Outdated
Show resolved
Hide resolved
.../java/org/openrewrite/java/testing/dbrider/ExecutionListenerToDbRiderAnnotationUnitTest.java
Show resolved
Hide resolved
.../java/org/openrewrite/java/testing/dbrider/ExecutionListenerToDbRiderAnnotationUnitTest.java
Outdated
Show resolved
Hide resolved
.../java/org/openrewrite/java/testing/dbrider/ExecutionListenerToDbRiderAnnotationUnitTest.java
Outdated
Show resolved
Hide resolved
.../java/org/openrewrite/java/testing/dbrider/ExecutionListenerToDbRiderAnnotationUnitTest.java
Outdated
Show resolved
Hide resolved
.../java/org/openrewrite/java/testing/dbrider/ExecutionListenerToDbRiderAnnotationUnitTest.java
Outdated
Show resolved
Hide resolved
.../java/org/openrewrite/java/testing/dbrider/ExecutionListenerToDbRiderAnnotationUnitTest.java
Outdated
Show resolved
Hide resolved
.../java/org/openrewrite/java/testing/dbrider/ExecutionListenerToDbRiderAnnotationUnitTest.java
Outdated
Show resolved
Hide resolved
.../java/org/openrewrite/java/testing/dbrider/ExecutionListenerToDbRiderAnnotationUnitTest.java
Outdated
Show resolved
Hide resolved
.../java/org/openrewrite/java/testing/dbrider/ExecutionListenerToDbRiderAnnotationUnitTest.java
Show resolved
Hide resolved
@timtebeek , Used a similar workaround like you did in the other one to resolve the test cases. |
src/main/java/org/openrewrite/java/testing/dbrider/ExecutionListenerToDbRiderAnnotation.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see! I've added some very light polish but with that we're good to merge. Thanks again!
Thank you for the patience in these ones and the great insights! |