-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assertInstanceOf
not converted from JUnit5 to assertJ
#606
assertInstanceOf
not converted from JUnit5 to assertJ
#606
Conversation
3952f19
to
9b6de84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/java/testing/junit5/EnclosedToNested.java
- lines 24-25
assertInstanceOf
not converted from JUnit5 to assertJ
Thanks for the suggestion! This likely needs a dedicated recipe, similar to the other examples seen here: rewrite-testing-frameworks/src/main/resources/META-INF/rewrite/assertj.yml Lines 459 to 468 in 8fb11c8
Anyone welcome to fill in the missing piece here to make it a reality. |
src/test/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThatTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThatTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/assertj/AssertJBestPracticesTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/assertj/AssertJBestPracticesTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThatTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThatTest.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThatTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply bot comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply bot comments
Co-authored-by: Tim te Beek <[email protected]>
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
…itly needed in a different order
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
…InstanceOfToAssertThat.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the help both! Great to convert these cases too.
What's changed?
What's your motivation?
Reproducing an observed conversion miss.
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
I'm not sure with sub recipe should convert this so I am using the best practices recipe as a catch-all.
Checklist