Convert assertTrue(false, String) and assertFalse(true, String) with fail(String)

[Laurens-W]

What's changed?

Add recipe to rewrite assertTrue(false, "message") and assertFalse(true, "message") to fail("message")

What's your motivation?

• Fixes convert AssertTrue(false) to fail #464

Anything in particular you'd like reviewers to focus on?

Test coverage

Anyone you would like to review specifically?

@timtebeek @timo-abele

Have you considered any alternatives or workarounds?

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

Awesome start, thanks! Did you notice this comment in the issue?

We could even implement this as a Refaster recipe, similar to what we recently added to rewrite-static-analysis in
openrewrite/rewrite-static-analysis#231

I think we can keep the tests, and replace the recipes with just a couple lines in Refaster recipes.

[Laurens-W]

Awesome start, thanks! Did you notice this comment in the issue?

We could even implement this as a Refaster recipe, similar to what we recently added to rewrite-static-analysis in
openrewrite/rewrite-static-analysis#231

I think we can keep the tests, and replace the recipes with just a couple lines in Refaster recipes.

Must admit I skimmed over that part :) I will continue working on this next week and apply the proposed changes!

[timtebeek]

Great to see! Let's merge the two separate test classes into a single AssertLiteralBooleanToFailRecipeTest, and within those I think we write a single test that covers all four cases from a single unit test that just has the four statements in one.

[timtebeek]

Neat addition; thanks @Laurens-W !