Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddJupiterDependencies now accepts transitive #507

Closed
wants to merge 1 commit into from

Conversation

nmck257
Copy link
Contributor

@nmck257 nmck257 commented Apr 15, 2024

What's changed?

see title

What's your motivation?

if you're using something like spring-boot-starter-test, then the current logic will add an arguably-redundant jupiter dependency. this change will make the recipe a little less noisy

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@nmck257
Copy link
Contributor Author

nmck257 commented Apr 15, 2024

actually just kidding; realized that I was testing with the old declarative version of this recipe, and the new imperative logic should actually handle this case since the getResolutionResult().findDependencies(...) check is transitive

@nmck257 nmck257 closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant