Unconditionally add the import for assertThrows, got a report where t…

…he template adds the method successfully but with missing type attribution for assertThrows so the import was missing
openrewrite · Nov 21, 2024 · a530dbe · a530dbe
1 parent f9cc74c
commit a530dbe
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/main/java/org/openrewrite/java/testing/junit5/ExpectedExceptionToAssertThrows.java b/src/main/java/org/openrewrite/java/testing/junit5/ExpectedExceptionToAssertThrows.java
@@ -182,7 +182,9 @@ public J.MethodDeclaration visitMethodDeclaration(J.MethodDeclaration methodDecl
                 m = m.withBody(m.getBody().withPrefix(thrown.get(0).getPrefix())).withThrows(Collections.emptyList());
             }
 
-            maybeAddImport("org.junit.jupiter.api.Assertions", "assertThrows");
+            // Unconditionally add the import for assertThrows, got a report where the above template adds the method successfully
+            // but with missing type attribution for assertThrows so the import was missing
+            maybeAddImport("org.junit.jupiter.api.Assertions", "assertThrows", false);
 
             if (expectMessageMethodInvocation != null && !isExpectMessageArgAMatcher && m.getBody() != null) {
                 m = JavaTemplate.builder("assertTrue(exception.getMessage().contains(#{any(java.lang.String)}));")

diff --git a/src/main/java/org/openrewrite/java/testing/junit5/UpdateTestAnnotation.java b/src/main/java/org/openrewrite/java/testing/junit5/UpdateTestAnnotation.java
@@ -150,7 +150,9 @@ public J.MethodDeclaration visitMethodDeclaration(J.MethodDeclaration method, Ex
                                 .build()
                                 .apply(updateCursor(m), m.getCoordinates().replaceBody(), cta.expectedException, lambda);
                         m = m.withThrows(Collections.emptyList());
-                        maybeAddImport("org.junit.jupiter.api.Assertions", "assertThrows");
+                        // Unconditionally add the import for assertThrows, got a report where the above template adds the method successfully
+                        // but with missing type attribution for assertThrows so the import was missing
+                        maybeAddImport("org.junit.jupiter.api.Assertions", "assertThrows", false);
                     }
                 }
                 if (cta.timeout != null) {