Skip to content

Commit

Permalink
Add unit tests for JMockit Delegate to mockito migration. Also add te…
Browse files Browse the repository at this point in the history 
…st case for comments (#557)

* Add unit tests for JMockit Delegate to mockito migration. Also add one test case for comments for JMockit Expectations proving that comments are not preserved.

* Update JMockitDelegateToMockitoTest.java

Modify test cases so that the tests fail with expected output of Delegate migration

* Update JMockitExpectationsToMockitoTest.java

Modify test to prove that comments migration is not supported within expectations, and this may be useful for someone who is adding this feature later. Disable test.

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update JMockitDelegateToMockitoTest.java

Modify tests to account for stubbing void methods using doAnswer instead of thenAnswer. Remove unnecessary imports

* Tag tests with associated issue

---------

Co-authored-by: Tim te Beek <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tim te Beek <[email protected]>
  • Loading branch information
@shivanisky @timtebeek @github-actions
4 people authored Aug 4, 2024
1 parent d067547 commit 533f37d
Show file tree
Hide file tree
Showing 2 changed files with 455 additions and 17 deletions.
366 changes: 366 additions & 0 deletions src/test/java/org/openrewrite/java/testing/jmockit/JMockitDelegateToMockitoTest.java
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,366 @@
/*
* Copyright 2023 the original author or authors.
* <p>
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* <p>
* https://www.apache.org/licenses/LICENSE-2.0
* <p>
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.openrewrite.java.testing.jmockit;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.openrewrite.DocumentExample;
import org.openrewrite.Issue;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;

import static org.openrewrite.java.Assertions.java;
import static org.openrewrite.java.testing.jmockit.JMockitTestUtils.setDefaultParserSettings;

/**
* At the moment, JMockit Delegates are not migrated to mockito. What I'm seeing is that they are being trashed
* with the template being printed out. These tests were written to try to replicate this issue, however I was unable to.
* They may help anyone who wants to add Delegate migration.
*/
@Disabled
@Issue("https://github.com/openrewrite/rewrite-testing-frameworks/issues/522")
class JMockitDelegateToMockitoTest implements RewriteTest {

@Override
public void defaults(RecipeSpec spec) {
setDefaultParserSettings(spec);
}

@DocumentExample
@Test
void whenNoArgsVoidMethod() {
//language=java
rewriteRun(
java(
"""
import mockit.Expectations;
import mockit.Delegate;
import mockit.Mocked;
import mockit.integration.junit5.JMockitExtension;
import org.junit.jupiter.api.extension.ExtendWith;
@ExtendWith(JMockitExtension.class)
class MyTest {
@Mocked
Object myObject;
void test() {
new Expectations() {{
myObject.wait();
result = new Delegate() {
public void wait() {
System.out.println("foo");
}
};
}};
myObject.wait();
}
}
""",
"""
import mockit.Delegate;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import static org.mockito.Mockito.when;
@ExtendWith(MockitoExtension.class)
class MyTest {
@Mock
Object myObject;
void test() {
doAnswer(invocation -> {
System.out.println("foo");
return null;
}).when(myObject).wait();
myObject.wait();
}
}
"""
)
);
}

@Test
void whenHasArgsVoidMethod() {
//language=java
rewriteRun(
java(
"""
import mockit.Expectations;
import mockit.Delegate;
import mockit.Mocked;
import mockit.integration.junit5.JMockitExtension;
import org.junit.jupiter.api.extension.ExtendWith;
@ExtendWith(JMockitExtension.class)
class MyTest {
@Mocked
Object myObject;
void test() {
new Expectations() {{
myObject.wait(anyLong);
result = new Delegate() {
void wait(long timeoutMs) {
System.out.println("foo");
System.out.println("bar");
}
};
}};
myObject.wait();
}
}
""",
"""
import mockit.Delegate;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import static org.mockito.Mockito.anyLong;
import static org.mockito.Mockito.when;
@ExtendWith(MockitoExtension.class)
class MyTest {
@Mock
Object myObject;
void test() {
doAnswer(invocation -> {
System.out.println("foo");
System.out.println("bar");
return null;
}).when(myObject).wait(anyLong());
myObject.wait();
}
}
"""
)
);
}

@Test
void whenNoArgsNonVoidMethod() {
//language=java
rewriteRun(
java(
"""
import mockit.Expectations;
import mockit.Delegate;
import mockit.Mocked;
import mockit.integration.junit5.JMockitExtension;
import org.junit.jupiter.api.extension.ExtendWith;
import static org.junit.jupiter.api.Assertions.assertEquals;
@ExtendWith(JMockitExtension.class)
class MyTest {
@Mocked
Object myObject;
void test() {
new Expectations() {{
myObject.toString();
result = new Delegate() {
String toString() {
String a = "foo";
return a + "bar";
}
};
}};
assertEquals("foobar", myObject.toString());
}
}
""",
"""
import mockit.Delegate;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.Mockito.when;
@ExtendWith(MockitoExtension.class)
class MyTest {
@Mock
Object myObject;
void test() {
when(myObject.toString()).thenAnswer(invocation -> {
String a = "foo";
return a + "bar";
});
assertEquals("foobar", myObject.toString());
}
}
"""
)
);
}

@Test
void whenMultipleStatementsWithAnnotation() {
//language=java
rewriteRun(
java(
"""
import mockit.Expectations;
import mockit.Delegate;
import mockit.Mocked;
import mockit.integration.junit5.JMockitExtension;
import org.junit.jupiter.api.extension.ExtendWith;
import static org.junit.jupiter.api.Assertions.assertEquals;
@ExtendWith(JMockitExtension.class)
class MyTest {
@Mocked
Object myObject;
void test() {
new Expectations() {{
myObject.hashCode();
result = 100;
myObject.toString();
result = new Delegate() {
@SuppressWarnings("unused")
String toString() {
String a = "foo";
return a + "bar";
}
};
}};
assertEquals(100, myObject.hashCode());
assertEquals("foobar", myObject.toString());
}
}
""",
"""
import mockit.Delegate;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.Mockito.when;
@ExtendWith(MockitoExtension.class)
class MyTest {
@Mock
Object myObject;
void test() {
when(myObject.hashCode()).thenReturn(100);
when(myObject.toString()).thenAnswer(invocation -> {
String a = "foo";
return a + "bar";
});
assertEquals(100, myObject.hashCode());
assertEquals("foobar", myObject.toString());
}
}
"""
)
);
}

@Test
void whenClassArgumentMatcher() {
//language=java
rewriteRun(
java(
"""
import java.util.List;
class MyObject {
public String getSomeField(List<String> input) {
return "X";
}
public String getSomeOtherField(Object input) {
return "Y";
}
}
"""
),
java(
"""
import java.util.ArrayList;
import java.util.List;
import mockit.Delegate;
import mockit.Mocked;
import mockit.Expectations;
import mockit.integration.junit5.JMockitExtension;
import org.junit.jupiter.api.extension.ExtendWith;
@ExtendWith(JMockitExtension.class)
class MyTest {
@Mocked
MyObject myObject;
void test() {
new Expectations() {{
myObject.getSomeField((List<String>) any);
result = new Delegate() {
String getSomeOtherField(List<String> input) {
input.add("foo");
return input.toString();
}
};
}};
myObject.getSomeField(new ArrayList<>());
myObject.getSomeOtherField(new Object());
}
}
""",
"""
import java.util.ArrayList;
import java.util.List;
import mockit.Delegate;
import static org.mockito.Mockito.anyList;
import static org.mockito.Mockito.when;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
@ExtendWith(MockitoExtension.class)
class MyTest {
@Mock
MyObject myObject;
void test() {
when(myObject.getSomeField(anyList())).thenAnswer(invocation -> {
List<String> input = invocation.getArgument(0);
input.add("foo");
return input.toString();
});
myObject.getSomeField(new ArrayList<>());
myObject.getSomeOtherField(new Object());
}
}
"""
)
);
}

}
Loading

0 comments on commit 533f37d

Please sign in to comment.