Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timer to Observation #2

Merged
merged 11 commits into from
Aug 30, 2023
Merged

Timer to Observation #2

merged 11 commits into from
Aug 30, 2023

Conversation

timtebeek
Copy link
Contributor

What's changed?

Added recipe to convert a timer to an observation.

What's your motivation?

#1

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

@timtebeek timtebeek self-assigned this Aug 15, 2023
@timtebeek timtebeek mentioned this pull request Aug 15, 2023
Open
@joanvr joanvr self-assigned this Aug 21, 2023
@joanvr joanvr marked this pull request as ready for review August 24, 2023 13:06
timtebeek
timtebeek commented Aug 24, 2023
View reviewed changes
Copy link
Contributor Author

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this push on the recipe! We can merge this part already and iterate from there.

timtebeek
timtebeek commented Aug 30, 2023
View reviewed changes
Copy link
Contributor Author

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise approved, apart from the last two unresolved threads. Thanks again!

@joanvr joanvr merged commit b4601a8 into main Aug 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanvr joanvr joanvr approved these changes

Assignees

@joanvr joanvr

@timtebeek timtebeek

Labels
recipe
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timtebeek @joanvr