Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use separate rewrite-polyglot version (#233) #235

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: use separate rewrite-polyglot version (#233) #235

merged 1 commit into from
Oct 10, 2023

Conversation

MagicalAsh
Copy link
Contributor

This commit fixes issue #233, where specifying a
rewriteVersion inside the rewrite configuration block would result in rewrite-polyglot failing to resolve to a proper version.

What's changed?

The rewrite-polyglot version can be configured independently from the rewrite version.

What's your motivation?

See #233.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ IDEA auto-formatter on affected files

This commit fixes issue #233, where specifying a
rewriteVersion inside the rewrite configuration block
would result in rewrite-polyglot failing to resolve
to a proper version.
@timtebeek
Copy link
Contributor

This seems to have been a bug of omission indeed, especially looking at how we have rewriteGradleModelVersion and rewriteKotlinVersion just below. Thanks for stepping up and getting that resolved!

@timtebeek timtebeek merged commit bd6372d into openrewrite:main Oct 10, 2023
1 check passed
@MagicalAsh
Copy link
Contributor Author

Awesome, thanks! Do you have a timeline on when this will be available in a release version?

@timtebeek
Copy link
Contributor

I'd expect a new release somewhere this week or next. There was one change we were waiting for, but I believe that hurdle had been cleared. You can already try the snapshot version of that helps you confirm the fix. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants