example #12 is done and ready for merge #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sowdm
requested changes
Oct 2, 2024
There was a problem hiding this comment.
A couple comments:
- source_url containing muckrock should be removed since those are not released by the PD
- If the same TableType from the same PD is spread across multiple datasets (or rows in the data source table), those datasets need to be combined and the years need to be the union of all the datasets' years. I'm not 100% sure, but I don't see this being done.
- I don't think the results that I'm getting for the stopped datasets bar chart matches what you showed me. Not sure what the issue is.
|
@potto216 Close this PR without merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.