Skip to content

Commit

Permalink
Merge pull request #83 from Gilead-BioStats/resubmission
Browse files Browse the repository at this point in the history
updated for resubmission
  • Loading branch information
xidongdxi authored Jul 2, 2024
2 parents 609eb7f + a73fd97 commit ea4f56d
Show file tree
Hide file tree
Showing 9 changed files with 41 additions and 26 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: graphicalMCP
Title: Graphical Multiple Comparison Procedures
Version: 0.2.1
Version: 0.2.2
Authors@R: c(
person("Dong", "Xi", , "[email protected]", role = c("aut", "cre")),
person("Ethan", "Brockmann", , "[email protected]", role = "aut"),
Expand Down
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,8 @@

* Corrected typos
* First CRAN release

# graphicalMCP 0.2.2

* Updated citations
* Resubmission for first CRAN release
4 changes: 2 additions & 2 deletions R/as_graph.R
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
#' @export
#'
#' @references
#' Cs{\'a}rdi, G., Nepusz, T., Traag, V., Horv{\'a}t, S., Zanini, F., Noom, D.,
#' and M{\"u}ller, K. (2024). \emph{igraph}: Network analysis and visualization
#' Csardi, G., Nepusz, T., Traag, V., Horvat, S., Zanini, F., Noom, D.,
#' and Mueller, K. (2024). \emph{igraph}: Network analysis and visualization
#' in R. R package version 2.0.3. \url{https://CRAN.R-project.org/package=igraph}.
#'
#' Rohmeyer, K., and Klinglmueller, K. (2024). \emph{gMCP}: Graph based
Expand Down
3 changes: 2 additions & 1 deletion R/graph_calculate_power.R
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,14 @@
#'
#' # Parametric tests for H1 and H2; Simes tests for H3 and H4
#' # User-defined success: to reject H1 or H2; to reject H1 and H2
#' # Reduce the number of simulations to save time for package compilation
#' graph_calculate_power(
#' g,
#' alpha,
#' test_groups = list(1:2, 3:4),
#' test_types = c("parametric", "simes"),
#' test_corr = list(corr1, NA),
#' sim_n = 1e5,
#' sim_n = 1e3,
#' sim_success = list(
#' function(.) .[1] || .[2],
#' function(.) .[1] && .[2]
Expand Down
11 changes: 5 additions & 6 deletions codemeta.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"codeRepository": "https://github.com/Gilead-BioStats/graphicalMCP",
"issueTracker": "https://github.com/Gilead-BioStats/graphicalMCP/issues",
"license": "Apache License 2",
"version": "0.2.1",
"version": "0.2.2",
"programmingLanguage": {
"@type": "ComputerLanguage",
"name": "R",
Expand Down Expand Up @@ -312,11 +312,11 @@
},
"SystemRequirements": null
},
"fileSize": "713.418KB",
"fileSize": "713.292KB",
"citation": [
{
"@type": "SoftwareSourceCode",
"datePublished": "2023",
"datePublished": "2024",
"author": [
{
"@type": "Person",
Expand All @@ -329,9 +329,8 @@
"familyName": "Brockmann"
}
],
"name": "{graphicalMCP}: Graph-based multiple comparison procedures.",
"url": "https://github.com/Gilead-BioStats/graphicalMCP",
"description": "version 0.1.0"
"name": "{graphicalMCP}: Graphical multiple comparison procedures",
"url": "https://github.com/Gilead-BioStats/graphicalMCP"
}
],
"relatedLink": "https://gilead-biostats.github.io/graphicalMCP/",
Expand Down
16 changes: 15 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
# Version 0.2.2

- This is the second submission to CRAN.
+ Updated citations to correct three notes.
+ Reduced the number of simulations in the example for `graph_calculate_power`
to correct one note regarding long run time.

## R CMD check results

0 errors | 0 warnings | 0 notes

# Version 0.2.1

- This is a new release and the first submission to CRAN.

## R CMD check results

0 errors | 0 warnings | 0 notes

* This is a new release.
19 changes: 7 additions & 12 deletions inst/CITATION
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
citHeader("To cite graphicalMCP in publications use:")

citEntry(
entry = "manual",
title = "{graphicalMCP}: Graph-based multiple comparison procedures.",
author = c("Dong Xi", "Ethan Brockmann"),
organization = "Gilead Sciences, Inc",
note = "version 0.1.0",
year = "2023",
url = "https://github.com/Gilead-BioStats/graphicalMCP",
textVersion = paste("Xi, D.; Brockmann, E. (2023).",
"graphicalMCP: Graph-based multiple comparison procedures.",
"version 0.1.0. Gilead Sciences, Inc. Foster City, California.",
"https://github.com/Gilead-BioStats/graphicalMCP")
bibentry(
"manual",
title = "{graphicalMCP}: Graphical multiple comparison procedures",
author = as.person("Dong Xi and Ethan Brockmann"),
edition = "version 0.2.2",
year = 2024,
url = "https://github.com/Gilead-BioStats/graphicalMCP"
)
4 changes: 2 additions & 2 deletions man/as_graph.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion man/graph_calculate_power.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ea4f56d

Please sign in to comment.