fix: ignore middleware rewrite when also redirecting #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
added
test all versions
📊 Package size report 0%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
|
(All the failures are for next@canary. We're working on fixing that, but it isn't related to this PR.) |
pieh
approved these changes
Aug 26, 2024
The Next.js behaviour is for a middleware redirect to take precedence over a middleware rewrite when both are present at once.
serhalp
force-pushed
the
serhalp/frp-1221-x-middleware-rewrite-header-overriding-middleware-redirects
branch
2 times, most recently
from
9807ff1 to
1ca23ce
Compare
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The (undocumented, untested) Next.js behaviour appears to be for a middleware redirect to take precedence over a middleware rewrite when both are present at once.
I was going to swap the order of evaluation of rewrites and redirects in
lib/responsebut then decided to go with a simpler "pretend there was no rewrite if there's a redirect" approach. I'm open to feedback here.Documentation
N/A
Tests
Added an integration test that was failing before this change. You can also create a simple repro site like this and see that it behaves differently with
next devthan via Netlify.Relevant links (GitHub issues, etc.) or a picture of cute animal
FRP-1221