refactor: remove unnecessary handling of Durable Cache feature flag after it was fully rolled out #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report -0.01%↓
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
force-pushed
the
test-update-after-durable-cache-fully-rolled-out
branch
from
96926e3 to
0aeb395
Compare
pieh
force-pushed
the
test-update-after-durable-cache-fully-rolled-out
branch
from
0aeb395 to
7c15344
Compare
pieh
commented
Aug 21, 2024
Comment on lines
+15
to
+16
| expect(headers['cache-status']).toMatch(/^"Next.js"; hit$/m) | ||
| expect(headers['cache-status']).toMatch(/^"Netlify Edge"; fwd=miss$/m) |
There was a problem hiding this comment.
This is alternative to previously merged updated assertions ( #2527 ) that does kind of preserve previous assertions and skips checking on "Netlify Durable" cache status
serhalp
approved these changes
Aug 21, 2024
pieh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating tests (mostly assertions) and removing unnecessary feature flag handling and conditional code paths after Durable Cache full rollout