ci(e2e): run e2e report cron after e2e tests finish #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
serhalp
force-pushed
the
ci/run-e2e-report-cron-after-e2e
branch
from
1be4f3b to
feb7850
Compare
eduardoboucas
approved these changes
Jun 28, 2024
We run the next.js repo e2e tests every day at 3am UTC but we were running the e2e report (which pulls the artefacts from the e2e workflow) every Wednesday at 3am UTC. We might as well defer it slightly and pull the data from the freshest run. In addition, since we weren't filtering on run status, it was almost always failing since the e2e report workflow queried for the most recent e2e test workflow run and, if it had already started, would fail to find its artefacts (because it had started but not completed). I fixed this by adding the missing status filter.
serhalp
force-pushed
the
ci/run-e2e-report-cron-after-e2e
branch
from
feb7850 to
4d7f806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We run the next.js repo e2e tests every day at 3am UTC but we were running the e2e report (which pulls the artefacts from the e2e workflow) every Wednesday at 3am UTC. We might as well defer it slightly and pull the data from the freshest run.
In addition, since we weren't filtering on run status, it was almost always failing since the e2e report workflow queried for the most recent e2e test workflow run and, if it had already started, would fail to find its artefacts (because it had started but not completed). Here's an example failed run. I fixed this by adding the missing status filter.
Documentation
N/A
Tests
I tested the
ghcommands locally.Relevant links (GitHub issues, etc.) or a picture of cute animal